Repository navigation
Conversation
isaacsa51
marked this pull request as ready for review
October 15, 2026 05:37
Owner
|
Hi @isaacsa51 can you resolve the conflicts with new changes? |
sameerasw
marked this pull request as draft
October 15, 2026 12:25
isaacsa51
marked this pull request as ready for review
October 15, 2026 18:56
Contributor
Author
|
ready now @sameerasw |
…plugin_handler # Conflicts: # app/src/main/java/com/sameerasw/essentials/island/plugins/notifications/NotificationsPlugin.kt # app/src/main/java/com/sameerasw/essentials/ui/features/display/IslandSubSettingsUI.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given any code that matches the regex for a OTP code or Single Code sign in, show island with copy and dismiss info with the code on the island.
That way if the user have the android heads up turn off via app, the Island gracefully show it to the user with different option to show from.
If the user enables this feature, in case that the app still don't have the Shizuku permission, once enable the user will be prompted to grant permission since android censors this types of notification since Android 14 afaik, granting access with ADB, shizuku
or root obvswill enable island to show this info.Type of change
UI changes
Showing island and code with default options and line peek mode:
Screen_recording_20261014_222457.mp4
while OTP testing can be difficult, this was tested using a real device using adb commands to mimick different cases of codes, arranging from 3 to 8 char codes, google OTPS like G-12345 and also depending on the email, long text still sometimes will match the logic, this depends on the notification data and it's preview to see if it's contain this.
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).