Per-instance UUID IDENTITY for daemon AsyncReqMessageClient (#69920) - #69922
Open
dwoz wants to merge 1 commit into
Open
Per-instance UUID IDENTITY for daemon AsyncReqMessageClient (#69920)#69922dwoz wants to merge 1 commit into
dwoz wants to merge 1 commit into
Conversation
…altstack#69920) Give each daemon AsyncReqMessageClient a per-instance uuid.uuid4().hex as its ZMQ IDENTITY, replacing the earlier process-wide _REQ_IDENTITY_SLOT counter and SALT_REQ_IDENTITY_SLOT_MAX cap. Each RequestClient is opened and closed by Salt itself, so a per-instance UUID matches the object's lifetime and gives the master ROUTER's routing-id table a 1:1 mapping to a client we control. Fork inheritance of the earlier counter -- root cause of saltstack#69753 -- is impossible by construction, since each child draws a fresh UUID.
dwoz
force-pushed
the
dwoz/perf/zmq-identity-slot-cap-3008x
branch
from
August 13, 2026 11:46
78bdf7f to
098e4be
Compare
dwoz
changed the title
twangboy
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69920
Summary
Give each daemon
AsyncReqMessageClienta per-instanceuuid.uuid4().hexasits ZMQ
IDENTITYslot, replacing the earlier process-wide_REQ_IDENTITY_SLOTcounter. EachRequestClientis opened andclosed by Salt itself, so a per-instance UUID matches the object's
lifetime and gives the master's ROUTER routing-id table a 1:1 mapping
to a client we control. Fork inheritance of the earlier counter (root
cause of #69753) is impossible by construction -- each child draws a
fresh UUID.
What this is not
This does not bound the master ROUTER routing-id table growth.
That story (MWorkerQueue RSS creep under sustained REQ churn) needs
a master-side eviction, tracked separately.
Also removed
_REQ_IDENTITY_SLOTmodule counterSALT_REQ_IDENTITY_SLOT_MAXenv override (never shipped in a release)Test plan
tests/pytests/unit/transport/test_zeromq_identity_uuid.py_CLI_IDENTITY_SLOTfor CLI-role sockets is unchanged.