Skip to content

[3.0.0 prep] Async packet sink (sending) - #405

Merged
Wojtek242 merged 3 commits into
rust-pcap:mainfrom
cicku:async-packet-sink
Sep 8, 2026
Merged

[3.0.0 prep] Async packet sink (sending)#405
Wojtek242 merged 3 commits into
rust-pcap:mainfrom
cicku:async-packet-sink

Conversation

@cicku

@cicku cicku commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Supersedes #373.

@cicku
cicku force-pushed the async-packet-sink branch 2 times, most recently from 1c75fa5 to 1918e47 Compare August 24, 2026 19:42
@cicku
cicku force-pushed the async-packet-sink branch 2 times, most recently from 1a3320b to d7c65d2 Compare September 2, 2026 16:51
@cicku
cicku marked this pull request as ready for review September 4, 2026 05:03
@cicku
cicku marked this pull request as draft September 4, 2026 15:52
@cicku
cicku marked this pull request as ready for review September 4, 2026 15:57
@cicku

cicku commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

This PR is only for sending packets - However, if #344 is looking for a singular solution, we can either:

  1. implement Sink on PacketStream where T = Active.
  2. make a separate Capture::duplex() returning a PacketDuplex that is both traits.

@cicku cicku changed the title [3.0.0 prep] Async packet sink [3.0.0 prep] Async packet sink (sending) Sep 4, 2026

@Wojtek242 Wojtek242 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment about a "magic constant"

Comment thread src/sink/mod.rs Outdated
@cicku
cicku force-pushed the async-packet-sink branch from 7d9f77c to 7cd32b6 Compare September 8, 2026 03:58
@Wojtek242
Wojtek242 merged commit a23877f into rust-pcap:main Sep 8, 2026
12 checks passed
@cicku
cicku deleted the async-packet-sink branch September 8, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants