[3.0.0 prep] tun_tap replacement - #402
Merged
Merged
Conversation
Contributor
Author
|
Ready: This PR only touches a test. |
cicku
marked this pull request as ready for review
August 31, 2026 02:33
tun-tap pulls tokio-core, and with it the whole 0.1 era async stack, to open a file descriptor and read from it. tun-rs does the same job with no runtime and no cc, which also means the tap tests no longer need a C compiler to build.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tun-tap (maintenance) pulls tokio-core, and with it the whole 0.1 era async stack, to open a file descriptor and read from it. tun-rs does the same job with no runtime and no cc, which also means the tap tests no longer need a C compiler to build.
This also shrinks the lock file.
Must be merged after #400, and a rebase will be done then.