Skip to content

ci: Resolve most zizmor findings as of zizmor@1.32.0 - #75

Draft
hashcatHitman wants to merge 7 commits into
rust-lang:mainfrom
hashcatHitman:zizmor
Draft

hashcatHitman wants to merge 7 commits into
rust-lang:mainfrom
hashcatHitman:zizmor

Conversation

@hashcatHitman

Copy link
Copy Markdown
Member

In pursuit of getting more zizmor lints enforced across rust-lang repos through crabwatch, this PR fixes most zizmor findings as of zizmor@1.32.0, using the auditor persona. The lints that actually fired per-persona level are:

regular persona findings:

pedantic persona findings:

auditor persona findings:

  • Everything from pedantic
  • Fixed in this PR:
    • None
  • Not fixed in this PR:
    • None

The hash pin format is supported by tools like Dependabot and Renovate, which can update the pinned hashes and their associated comments. If you'd like help setting either of those up, let me know which you prefer, and if you'd like it in this PR or a new one. By default, I'd assume to set it up to only update GitHub Actions.

See: https://github.com/actions/checkout/releases/tag/v4.4.0

This is the same version we're already implicitly using.

Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/bytecodealliance/actions/releases/tag/v1.1.3

This is the same version we're already implicitly using.

Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
@hashcatHitman

Copy link
Copy Markdown
Member Author

r? crabwatch

@hashcatHitman

Copy link
Copy Markdown
Member Author

Okay, no r?. Coin flip again. Heads=Marco.

@hashcatHitman

Copy link
Copy Markdown
Member Author
$ fend 1d2
  1: 50.00%  ##############################
  2: 50.00%  ##############################

$ fend roll 1d2
1

cc @marcoieni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: zizmor PR opened

Development

Successfully merging this pull request may close these issues.

1 participant