Skip to content

pr-labeler: remove stale labels#648

Open
jamillambert wants to merge 1 commit into
rust-bitcoin:masterfrom
jamillambert:0625-pr-labler
Open

pr-labeler: remove stale labels#648
jamillambert wants to merge 1 commit into
rust-bitcoin:masterfrom
jamillambert:0625-pr-labler

Conversation

@jamillambert

Copy link
Copy Markdown
Collaborator

The PR labeler only adds labels based on changed file paths. If the PR no longer touches certain paths the labels are not removed.

When running compare the paths touched to the existing labels and remove any from the managed label set that no longer apply.

Add comments to clarify that it is only labels from the managed set that are added or removed automatically.

Assisted-by: GPT-5.4 (The LLM wrote the section that removes the labels).

Closes #637

The PR labeler only adds labels based on changed file paths. If the PR
no longer touches certain paths the labels are not removed.

When running compare the paths touched to the existing labels and
remove any from the managed label set that no longer apply.

Add comments to clarify that it is only labels from the managed set that
are added or removed automatically.

Assisted-by: GPT-5.4

@satsfy satsfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a6f27e1

So I merged this into master of my local fork. Then, in PR satsfy#45, I created a PR changing the client/ and pushed the commit. The client label was added. Then I reverted the change from client/ to types/ (resetting PR diff to client/) and it removed the client label and added types label. I redid for electrsd and it also worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR labeller is wonky

2 participants