Conversation
anvacaru
marked this pull request as ready for review
July 13, 2026 06:44
anvacaru
marked this pull request as draft
July 21, 2026 13:46
…gate #isPrecompiledAccount fallback with owise so P256VERIFY dispatches The general #isPrecompiledAccount rule overlapped the schedule-specific [isPrecompiledAccountOsaka] rule and won for (256, OSAKA), returning 256 <=Int 17 = false. CALL/tx to 0x100 was therefore treated as an empty account: the precompile never dispatched, so no gas was charged and insufficient-gas calls wrongly succeeded. Marking the fallback [owise] lets the specific rule take priority, matching the sibling #precompiledAccountsSet definition. Unmask the 12 eip7951 fixtures that now pass; test_precompile_before_fork stays masked (transition fixture, single-schedule harness limitation). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing EIP-7951 and adding a new P256Verify precompiled account at address 0x100.
blocked on
runtimeverification/blockchain-k-plugin#219.