Skip to content

Remove readline-win32 from vcpkg - #43

Merged
ntkme merged 1 commit into
mainfrom
remove-vcpkg-readline
Nov 16, 2026
Merged

ntkme merged 1 commit into
mainfrom
remove-vcpkg-readline

Conversation

@ntkme

@ntkme ntkme commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

I was comparing the vcpkg.json used here and https://github.com/ruby/ruby/blob/HEAD/vcpkg.json.

The existing ruby-loco mswin is ruby 4.1 as of now, and it seems we're only going to provide mswin builds for ruby >=3.4 in ruby/setup-ruby#971. Therefore I think we don't need readline-win32 out of box anymore.

The other extra package here that ruby upstream does not have is pkgconf, but I suppose some gems' native extensions might need it so I kept it for now.

@ntkme
ntkme requested a review from hsbt November 13, 2026 21:08

@hsbt hsbt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, ext/readline was removed in Ruby 3.3 and ruby/ruby's own vcpkg.json doesn't include it, so the current mswin doesn't need it.

@ntkme
ntkme merged commit 590300b into main Nov 16, 2026
30 checks passed
@ntkme
ntkme deleted the remove-vcpkg-readline branch November 16, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants