Repository navigation
Remove readline-win32 from vcpkg - #43
Merged
Merged
Conversation
hsbt
approved these changes
Nov 16, 2026
hsbt
left a comment
Member
There was a problem hiding this comment.
Right, ext/readline was removed in Ruby 3.3 and ruby/ruby's own vcpkg.json doesn't include it, so the current mswin doesn't need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was comparing the
vcpkg.jsonused here and https://github.com/ruby/ruby/blob/HEAD/vcpkg.json.The existing ruby-loco mswin is ruby 4.1 as of now, and it seems we're only going to provide mswin builds for ruby >=3.4 in ruby/setup-ruby#971. Therefore I think we don't need
readline-win32out of box anymore.The other extra package here that ruby upstream does not have is
pkgconf, but I suppose some gems' native extensions might need it so I kept it for now.