Skip to content

Fix line wrap for workingDir in the Workbench launcher Job template - #970

Closed
bcpierson-lilly wants to merge 1 commit into
rstudio:mainfrom
bcpierson-lilly:fix/workbench-working-directory-yaml
Closed

bcpierson-lilly wants to merge 1 commit into
rstudio:mainfrom
bcpierson-lilly:fix/workbench-working-directory-yaml

Conversation

@bcpierson-lilly

@bcpierson-lilly bcpierson-lilly commented Oct 29, 2026 •

Copy link
Copy Markdown

Closes #969

toYaml can wrap long directory paths at spaces. The Workbench launcher Job template currently leaves continuation lines at the wrong indentation for field workingDir, producing invalid YAML that Kubernetes rejects before the job runs.

This applies the same indent / trimPrefix pattern used for other fields, including the earlier correction in 1986ad3. The decoded working-directory string remains unchanged.

  • Correct the workingDir expression.
  • Add a Helm unit test asserting that the emitted template includes continuation indentation.
  • Bump the chart version to 0.22.9 and update the changelog and generated README.

Validation

  • All 175 Workbench chart unit tests passed.
  • Strict Helm lint passed for all 15 lint values files.
  • Separate local rendering tests passed for eight working-directory cases, including long paths with spaces, quotes, Unicode, and embedded newlines.
  • Removing the correction reproduced the YAML parsing failure for the long spaced-path case.

@bcpierson-lilly
bcpierson-lilly requested a review from a team October 29, 2026 20:30
@bcpierson-lilly
bcpierson-lilly marked this pull request as draft October 29, 2026 20:40
@bcpierson-lilly

Copy link
Copy Markdown
Author

Drafting while checking on the CLA

@bcpierson-lilly
bcpierson-lilly deleted the fix/workbench-working-directory-yaml branch October 30, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workbench Job template produces invalid YAML for long working directories containing spaces

1 participant