Skip to content

fix non standard interface locations. (#1186) (backport #1283) - #1291

Merged
ahcorde merged 2 commits into
humblefrom
mergify/bp/humble/pr-1283
Aug 31, 2026
Merged

ahcorde merged 2 commits into
humblefrom
mergify/bp/humble/pr-1283

Conversation

@mergify

@mergify mergify Bot commented Aug 31, 2026

Copy link
Copy Markdown

Description

Replace #1205 because it was targeting kilted

Fixes # (issue)

Instead of relying on the broken get_interface_path function, I use the rosidl_interfaces resource directly. (see ros2/rosidl#935 (comment))

Fixes #1186


This is an automatic backport of pull request #1283 done by [Mergify](https://mergify.com).

Signed-off-by: Tim Wendt <techtasie@gmail.com>
Co-authored-by: Tim Wendt <techtasie@gmail.com>
(cherry picked from commit 7c6e097)

# Conflicts:
#	ros2interface/ros2interface/verb/show.py
@mergify mergify Bot added the conflicts label Aug 31, 2026
@mergify

mergify Bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Cherry-pick of 7c6e097 has failed:

On branch mergify/bp/humble/pr-1283
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 7c6e097.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ros2interface/test/test_cli.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ros2interface/ros2interface/verb/show.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde

ahcorde commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Pulls: #1291
Gist: https://gist.githubusercontent.com/ahcorde/88c53be9876122d2d3132931a63825af/raw/cd8fa8db4d9eefb926972aba9859bd7afc8ce37e/ros2.repos
BUILD args: --packages-above-and-dependencies ros2interface
TEST args: --packages-above ros2interface
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20284

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
ahcorde merged commit fb1fc2a into humble Aug 31, 2026
2 checks passed
@ahcorde
ahcorde deleted the mergify/bp/humble/pr-1283 branch August 31, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant