make the database-backed tests Sage-clean#87
Merged
Conversation
Test-only. Three DB-backed tests were written against plain Python and failed under sage -python, which CI never runs on these files but a developer with Sage does: one asserted "sage" not in sys.modules (now skipped under Sage, since it exists to pin the sage-free path), one compared a numeric sum against Decimal (now compared against the exact int, which both modes satisfy), and one asserted int/float types that are Integer/LmfdbRealLiteral under Sage (now branched on SAGE_MODE). The full suite now passes identically under both interpreters. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Review caught that "not isinstance(..., float)" also admits Decimal, despite the comment promising Decimal never escapes. The integral entries are now asserted to be int without Sage and sage Integer with it, in both the scalar and the array case. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
Review addressed: the weak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only. Three DB-backed tests were written against plain Python and failed under
sage -python, which CI never runs on these files but a developer with Sage does: one asserted"sage" not in sys.modules(now skipped under Sage, since it exists to pin the sage-free path), one compared a numeric sum againstDecimal(now compared against the exact int, which both modes satisfy), and one assertedint/floattypes that areInteger/LmfdbRealLiteralunder Sage (now branched onSAGE_MODE). The full suite now passes identically under both interpreters.Split out of #60 (one PR per issue). This branch carries only this issue's fix and its tests; the rest of the known-bug inventory stays
xfailed, so the full suite is green here and the strict markers guarantee no cross-issue leakage.