type coercion misses options with a bare dest#86
Merged
Conversation
Configuration.get() looks up option types under "<section>_<key>", but the type table is keyed by argparse dest, which for misc-section options is the bare key — so those options skipped coercion entirely and a store_true default came back as the string "False", which is truthy. The lookup now reconstructs the dest for both shapes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration.get()looks up option types under"<section>_<key>", but the type table is keyed by argparse dest, which formisc-section options is the bare key — so those options skipped coercion entirely and astore_truedefault came back as the string"False", which is truthy. The lookup now reconstructs the dest for both shapes.Split out of #60 (one PR per issue). This branch carries only this issue's fix and its tests; the rest of the known-bug inventory stays
xfailed, so the full suite is green here and the strict markers guarantee no cross-issue leakage.