DelayCommit silencing is broken in two ways#82
Merged
Conversation
DelayCommit(silence=True) wrote obj._silenced, but base.py reads and the exit path restores obj._db._silenced — so silencing was a no-op unless the context object *was* the database. Fixed to set the attribute that is actually read, and verified against the real logging machinery rather than a mock. That exposed the second half: silence= was applied even when active=False, but __exit__ only restores under active — and reload_all uses exactly DelayCommit(..., silence=True, active=False), which would have silenced the database permanently. The flag is now gated on active. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DelayCommit(silence=True)wroteobj._silenced, but base.py reads and the exit path restoresobj._db._silenced— so silencing was a no-op unless the context object was the database. Fixed to set the attribute that is actually read, and verified against the real logging machinery rather than a mock.That exposed the second half:
silence=was applied even whenactive=False, but__exit__only restores underactive— andreload_alluses exactlyDelayCommit(..., silence=True, active=False), which would have silenced the database permanently. The flag is now gated onactive.Split out of #60 (one PR per issue). This branch carries only this issue's fix and its tests; the rest of the known-bug inventory stays
xfailed, so the full suite is green here and the strict markers guarantee no cross-issue leakage.