max()/min() crash instead of raising the documented error#62
Merged
Conversation
max() and min() on a table (or constraint) with no non-null values raised TypeError: 'NoneType' object is not subscriptable from fetchone() on an empty cursor. Their docstrings promise an error, so this replaces the accident with a deliberate ValueError("no non-null values of %s in %s"); _slow_statistic gains the missing empty-cursor guards. If None is preferred over an exception, say so — it is a three-line change — but the docstring won the tie here.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max()andmin()on a table (or constraint) with no non-null values raisedTypeError: 'NoneType' object is not subscriptablefromfetchone()on an empty cursor. Their docstrings promise an error, so this replaces the accident with a deliberateValueError("no non-null values of %s in %s");_slow_statisticgains the missing empty-cursor guards. IfNoneis preferred over an exception, say so — it is a three-line change — but the docstring won the tie here.Split out of #60 (one PR per issue). This branch carries only this issue's fix and its tests; the rest of the known-bug inventory stays
xfailed, so the full suite is green here and the strict markers guarantee no cross-issue leakage.