Repository navigation
fix(broadcasts): add topic_id to the Broadcast response type - #299
Merged
Merged
Conversation
The API returns topic_id when you get a broadcast, but the Broadcast TypedDict did not declare it, so strict mypy rejected the key.
klotty
approved these changes
Oct 15, 2026
klotty
left a comment
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds the optional topic_id field to the Broadcast response type and tests it with null and non-null values; no runtime behavior changes, so the change is bounded and clearly beneficial.
View guided diff | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type checkers now accept
topic_idwhen you read a broadcast. The API already returns the field, but the response type did not declare it, so strict mypy rejected the key.Not covered. Six other broadcast response fields can be null, but the SDK still types them as strings. A nullable type can break type checks in user code, so that change needs its own release decision.
Summary by cubic
Declares
topic_idon theBroadcastresponse type so strict type checkers accept the field. The API already returns it, so there's no runtime behavior change.Not covered
Written for commit 5dac853. Summary will update on new commits.