Skip to content

fix(broadcasts): add topic_id to the Broadcast response type - #299

Merged
felipefreitag merged 1 commit into
mainfrom
fix-broadcast-response-topic-id
Oct 15, 2026
Merged

felipefreitag merged 1 commit into
mainfrom
fix-broadcast-response-topic-id

Conversation

@felipefreitag

@felipefreitag felipefreitag commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Type checkers now accept topic_id when you read a broadcast. The API already returns the field, but the response type did not declare it, so strict mypy rejected the key.

Not covered. Six other broadcast response fields can be null, but the SDK still types them as strings. A nullable type can break type checks in user code, so that change needs its own release decision.


Summary by cubic

Declares topic_id on the Broadcast response type so strict type checkers accept the field. The API already returns it, so there's no runtime behavior change.

Not covered

  • Six other broadcast response fields can be null but are still typed as strings, which can break type checks in user code.

Written for commit 5dac853. Summary will update on new commits.

View guided diff

The API returns topic_id when you get a broadcast, but the Broadcast
TypedDict did not declare it, so strict mypy rejected the key.

@klotty klotty left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Adds the optional topic_id field to the Broadcast response type and tests it with null and non-null values; no runtime behavior changes, so the change is bounded and clearly beneficial.

View guided diff | Re-trigger cubic

@felipefreitag
felipefreitag merged commit 063f797 into main Oct 15, 2026
32 checks passed
@felipefreitag
felipefreitag deleted the fix-broadcast-response-topic-id branch October 15, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants