Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Wait for the cached schema before deciding whether to use it after an HTTP error. When an ETag exists but the cached file is missing, preserve the original request error instead of resolving undefined. Keep existing cached content, including an empty string.
What issues does this PR fix or reference?
A self-contained schema-cache fallback bug reproduced with a real HTTP 404 response and a missing cache entry. This does not change proxy handling or cache invalidation policy.
Is it tested? How?
Four HTTP-backed extension-host regressions cover a missing cached file, no ETag, an empty cached response and a usable cached schema. The missing-file regression fails before the change and passes after it.
Fork CI: https://github.com/h55n/vscode-yaml/actions/runs/41652565094
Local VSIX packaging also passes. The temporary fork-only CI workflow is excluded from this PR.
AI assistance was used during development and testing.