Skip to content

fix: preserve HTTP errors when schema cache is missing - #1307

Open
h55n wants to merge 1 commit into
redhat-developer:mainfrom
h55n:fix/schema-cache-fallback-final
Open

h55n wants to merge 1 commit into
redhat-developer:mainfrom
h55n:fix/schema-cache-fallback-final

Conversation

@h55n

@h55n h55n commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Wait for the cached schema before deciding whether to use it after an HTTP error. When an ETag exists but the cached file is missing, preserve the original request error instead of resolving undefined. Keep existing cached content, including an empty string.

What issues does this PR fix or reference?

A self-contained schema-cache fallback bug reproduced with a real HTTP 404 response and a missing cache entry. This does not change proxy handling or cache invalidation policy.

Is it tested? How?

Four HTTP-backed extension-host regressions cover a missing cached file, no ETag, an empty cached response and a usable cached schema. The missing-file regression fails before the change and passes after it.

Fork CI: https://github.com/h55n/vscode-yaml/actions/runs/41652565094

  • Windows 2025, macOS 15 and Ubuntu 24.04: build passes; extension-host suite 84 passing and 12 existing pending cases per OS; UI-driver suite 5 passing per OS.
  • Ubuntu desktop smoke: 2 passing. Chromium web smoke: 2 passing.
  • Local lint and production build pass.

Local VSIX packaging also passes. The temporary fork-only CI workflow is excluded from this PR.

AI assistance was used during development and testing.

@h55n
h55n requested a review from datho7561 as a code owner November 3, 2026 15:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant