Skip to content

chore(imageupdater): sync Image Updater CRD with upstream#1175

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:masterfrom
dkarpele:dk-GITOPS-9973-master
Jun 11, 2026
Merged

chore(imageupdater): sync Image Updater CRD with upstream#1175
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:masterfrom
dkarpele:dk-GITOPS-9973-master

Conversation

@dkarpele

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What does this PR do / why we need it:
Sync Image Updater CRD with argocd operator https://github.com/argoproj-labs/argocd-operator/blob/master/config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
https://redhat.atlassian.net/browse/GITOPS-9973
Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 41cc312e-815d-405e-a414-81200e9b8a82

📥 Commits

Reviewing files that changed from the base of the PR and between f17e9b5 and 88706f1.

📒 Files selected for processing (3)
  • bundle/manifests/argocd-image-updater.argoproj.io_imageupdaters.yaml
  • bundle/manifests/gitops-operator.clusterserviceversion.yaml
  • config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml
✅ Files skipped from review due to trivial changes (1)
  • bundle/manifests/gitops-operator.clusterserviceversion.yaml

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Add pull request / merge request support for write-back via GitHub or GitLab.
  • Changes

    • Enhanced status and table output with aggregate metrics: applications matched, images managed, last-checked time, last-updated and readiness.
    • Replace per-image status with recent update history and aggregate fields; removed a deprecated namespace field.

Walkthrough

This PR updates the ImageUpdater CustomResourceDefinition to add pull request/merge request creation support in Git write-back configurations, redesign the status schema to use aggregate fields and a recent updates array, and add printer columns for status visibility. Changes are mirrored across both the source CRD and bundled manifest files.

Changes

ImageUpdater CRD Enhancement: Pull Request Support and Status Schema Redesign

Layer / File(s) Summary
Pull Request Configuration in Git Write-Back
bundle/manifests/argocd-image-updater.argoproj.io_imageupdaters.yaml, config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml
Adds pullRequest block with github and gitlab sub-objects and x-kubernetes-validations rule enforcing exactly one at both selector-level and global writeBackConfig.gitConfig in both manifests.
Status Schema Redesign
bundle/manifests/argocd-image-updater.argoproj.io_imageupdaters.yaml, config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml
Replaces prior imageStatus and reconciledAt with new top-level fields (applicationsMatched, imagesManaged, lastCheckedAt, lastUpdatedAt, observedGeneration) and introduces recentUpdates array containing RecentUpdate object schema in both manifests.
Status Display Columns
bundle/manifests/argocd-image-updater.argoproj.io_imageupdaters.yaml, config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml
Adds additionalPrinterColumns to the v1alpha1 version to surface applicationsMatched, imagesManaged, lastCheckedAt, and Ready condition status in both manifests.
Manifest Metadata Updates
config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml, bundle/manifests/gitops-operator.clusterserviceversion.yaml
Removes metadata.creationTimestamp from source CRD and updates ClusterServiceVersion createdAt timestamp in bundle metadata.

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(imageupdater): sync Image Updater CRD with upstream' directly describes the main change—syncing the Image Updater CRD with upstream Argo CD Operator.
Description check ✅ Passed The description explains the PR's purpose (syncing the Image Updater CRD with upstream), references the upstream repository, and links to the related issue, making it clearly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: dkarpele <karpelevich@gmail.com>
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown

Hi @dkarpele. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dkarpele dkarpele force-pushed the dk-GITOPS-9973-master branch from f17e9b5 to 88706f1 Compare June 11, 2026 15:13
@svghadi

svghadi commented Jun 11, 2026

Copy link
Copy Markdown
Member

/ok-to-test
/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 97ce1af into redhat-developer:master Jun 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants