[CodeQuality] Skip same boolean in both branches in SimplifyIfReturnBoolRector#8159
Merged
Merged
Conversation
3ed0fe8 to
85dab1d
Compare
85dab1d to
7e49e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9798
When both the
ifbranch and the trailing statement return the same boolean, the condition does not affect the result, yetSimplifyIfReturnBoolRectorrewrote it using the condition — producing a wrong result and dropping the condition's side effect.Before (buggy output)
was rewritten to:
After
Left unchanged — both branches return the same boolean, so the rule now bails out.
Fix
shouldSkipIfAndReturn()now skips when the inner return and the trailing return are the same boolean value.