[CodingStyle] Add AlternativeIfToBracketRector#8158
Merged
Conversation
…ternative syntax to bracket syntax
Member
|
There is already rule for it: |
Member
Author
|
It's slightly different rule. I could not find any fixture handling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8157.
Adds
AlternativeIfToBracketRector(CodingStyle) that converts the alternativeif/elseif/else/endifcontrol syntax to bracket syntax. Complements #8157, whereShortenElseIfRectornow skips alternative syntax rather than producing broken mixed output — this rule lets you normalize such files to braces instead.Change
Full chain:
How
Detects alternative syntax with the same
getOldTokens()scan used by the siblingCompleteMissingIfElseBracketRector(a:before{after the condition), then clearsORIGINAL_NODEon theif, itselseifs andelseto force a bracket reprint. Bracket syntax is left untouched. ImplementsHTMLAverseRectorInterfaceso template files mixing inline HTML are skipped.