[PHPUnit120] Skip stub-only ->method() calls in AllowMockObjectsForDataProviderRector - #790
Merged
Merged
Conversation
…taProviderRector createStub() returns a Stub, which never requires expectations, so a data-provided test using only stubs must not get the #[AllowMockObjectsWithoutExpectations] attribute. Fixes rectorphp/rector#9920 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9920
What
AllowMockObjectsForDataProviderRectoradded#[AllowMockObjectsWithoutExpectations]to test classes whose data-provided tests only usecreateStub().Why
MockObjectExprDetector::hasMethodCallWithoutExpects()matched any$var->method(...)call without checking the receiver's type. Stubs (PHPUnit\Framework\MockObject\Stub) never require expectations, so they should not trigger the attribute.How
The detector now resolves the receiver's type. It skips
->method()calls on expressions that are definitely aStubbut not aMockObject. Unknown or mixed types keep the previous behaviour, so the change stays conservative.Tests
skip_stub_only.php.inc. It failed before the fix and passes now.main, none of them in the touched file.AI disclosure: this change was prepared with the help of Claude Code and reviewed by me.
🤖 Generated with Claude Code