Repository navigation
Add InheritsVisibleProperty for parent property visibility lookup - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors
InheritsVisibleMethodfor properties: walks a class's parent chain and reports whether an ancestor declares a given propertyprotectedorpublic- the visibilities PHP forbids a subclass redeclaration from reducing below.The registry now records each property's declared visibility (plain declarations and constructor-promoted parameters), so a consumer can tell whether narrowing a property to
privatewould break the inheritance constraint.Enables a privatize-final-class-protected-properties rule in reco, the property counterpart to the existing protected-methods rule.