Contextualization - #58
Draft
JayPanoz wants to merge 63 commits into
Draft
Conversation
handle mixed in a generic way so that we can reuse it for other roles, if required in the future.
This will be specc’d in the future
Addressing CSS Selector gaps with Go Toolkit + introducing DOM Ranges
+ Reorg converter and rename cssSelector
dt > dfn surfaced the issue, but bad markup could result in duplicated roles too.
So that controls do not ovelay them
Volume, rate, pitch must be handled smartly as otherwise, the change appears non-responsive as it will only apply to the next utterance, not the current one.
Safeguard about invalid/misparsed CSS Selectors
This was shallow merged, thus losing nested keys in the process.
Chances are md will not be up-to-date and vice-versa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs address contextualisation of utterances, per spec – that is private but will eventually be published in docs.
Draft because the spec is still being laid out for some verbosity levels.