Repository navigation
Clarify JSX parsing with Babel in installation guide - #8692
Open
sahilbhandare45 wants to merge 1 commit into
Open
sahilbhandare45 wants to merge 1 commit into
sahilbhandare45 wants to merge 1 commit into
Conversation
Add note about JSX parsing requirements when using Babel.
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Babel section of the installation page shows a config with only babel-plugin-react-compiler. Run directly (for example with @babel/cli) on .jsx files, that config stops with “Support for the experimental syntax ‘jsx’ isn’t currently enabled”, because the plugin doesn’t turn on JSX parsing and Babel fails before the compiler runs.
This adds a Note saying to include @babel/preset-react or @babel/plugin-syntax-jsx, and that presets run after plugins, so the compiler still runs first.
I checked this with @babel/core and @babel/cli 7.29 and 8.0 and babel-plugin-react-compiler 1.0.0: the plugin alone fails, adding either option compiles, and the output is memoized.
Related issue: react/react#37727