Skip to content

[iOS] Sync drifted internal fixes for the status bar stub and scroll content view - #60078

Merged
cipolleschi merged 1 commit into
react:mainfrom
javache:fix-shipit-drift-T298179666
Nov 17, 2026
Merged

cipolleschi merged 1 commit into
react:mainfrom
javache:fix-shipit-drift-T298179666

Conversation

@javache

@javache javache commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary:

Brings two small iOS fixes that landed internally but were not exported to GitHub, so main matches the internal repository again:

Changelog:

[Internal]

Test Plan:

  • Both changes are already landed and built internally (tvOS, iOS and macOS builds).
  • node_modules/.bin/clang-format --dry-run --Werror on both files: no issues.
  • I did not run a local Xcode build of this branch.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Visual regression

No visual differences at 7e87d46abaeb.

android: no capture

@meta-codesync

meta-codesync Bot commented Nov 17, 2026

Copy link
Copy Markdown

@javache has imported this pull request. If you are a Meta employee, you can view this in D132564249.

@javache javache closed this Nov 17, 2026
@javache javache reopened this Nov 17, 2026
…content view

Summary:
Brings two internal fixes to GitHub that ShipIt did not export, resolving part of the DiffTrain sync drift on `main`:

- Add `getVerticalBarEdge` to the unsupported-platform `RCTStatusBarManager` stub, returning `nil`, so it conforms to the native module spec on tvOS after react#59237.
- Declare `RCTScrollContentViewCls` with `RCT_EXTERN` in `RCTScrollContentViewComponentView.h`, matching its component registration linkage (part of the internal import of react#59836).

Changelog: [Internal]

Test Plan:
Both changes are already landed and built internally (tvOS, iOS and macOS). The resulting files match the internal copies.
@cipolleschi
cipolleschi force-pushed the fix-shipit-drift-T298179666 branch from 1072b44 to 7e87d46 Compare November 17, 2026 16:13
@cipolleschi
cipolleschi enabled auto-merge (squash) November 17, 2026 16:13
@cipolleschi
cipolleschi merged commit de52d6f into react:main Nov 17, 2026
81 checks passed
@javache
javache deleted the fix-shipit-drift-T298179666 branch November 17, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fh:direct-merge-enabled p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants