MR/MRX/MRY terminate operators with markers in Crumble or else produce an error (magenta mark)#1086
Open
frederikwilde wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: The changes in this PR were written in part by Claude Code; my non-existent JS skills would have produced much lower-quality code. But I reviewed everything and this PR text is written by me. If this can't be merged for legal reasons, perhaps it can serve as a basis for a future patch.
The documentation states that the circuit
M 0; R 0should be equivalent toMR 0, but in Crumble there is a divergence of the two. An incoming Z operator passes throughMand causes an error atRif not captured by aMARKZ(first row in upper figure). ForMRthe behavior deviates: the operator simply passes through (third row in upper figure).Trying to capture the operator with a
MARKZwill just create a new operator (second row in upper figure).The fix is to first handle potential inbound operators upon measurement and then creating an error (magenta mark) at the reset if applicable.
Upstream:
This PR (the behavior I'd expect):
