Fix Interpolator return type being a generator - #132
Conversation
Also clarify language around kx_/ky_ arguments which are flipped from typical geotiepoints convention. Normally x is columns (cross-track) and y is rows (along-track), but `RectBivariateSpline` was provided coordinates in the (y, x) order so the `kx_` argument is rows/along-track and `ky_` is columns/cross-track.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 89.58% 89.74% +0.16%
==========================================
Files 20 20
Lines 1517 1541 +24
==========================================
+ Hits 1359 1383 +24
Misses 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@mraspaud Claude says you're basically the sole author of all of this stuff so I think that means you have to review it. |
|
I remember I've pair-programmed with Adam 10+ years ago on parallellizing something, but I think that's it. Looks like something Martin needs to check anyway, so I'll remove myself from reviewers. |
mraspaud
left a comment
There was a problem hiding this comment.
LGTM
Does it mean we go from lazy to eager? I guess that doesn't really matter in practice, just curious.
|
Correct, but the only use Claude found for this was in Satpy where it is immediately unpacked: |
Also clarify language around kx_/ky_ arguments which are flipped from typical geotiepoints convention. Normally x is columns (cross-track) and y is rows (along-track), but
RectBivariateSplinewas provided coordinates in the (y, x) order so thekx_argument is rows/along-track andky_is columns/cross-track.Written by Claude with a lot of feedback from me.
@pnuu I never remember if you're part of geotiepoints development. Let me know and feel free to remove yourself from the reviewers.
git diff origin/main **/*py | flake8 --diff