gh-131798: Propagate iterator types from GET_ITER in the JIT - #157011
Open
lgeiger wants to merge 1 commit into
Open
gh-131798: Propagate iterator types from GET_ITER in the JIT#157011lgeiger wants to merge 1 commit into
lgeiger wants to merge 1 commit into
Conversation
lgeiger
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
September 5, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR propagates the iterator result types for dicts and sets in the jit optimiser.
This removes a
_GUARD_TYPE_ITERguard whenGET_ITERandFOR_ITERare in the same trace.I ran a small microbenchmark on macOS aarch64 that repeatedly iterated over small dictionaries and sets: it seems like this change shows up a 1% improvement, but results are very noisy.