Skip to content

bpo-25457: Remove sorting bug in json._iterencode_dict #15691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yoann9344 wants to merge 2 commits into from
Closed

bpo-25457: Remove sorting bug in json._iterencode_dict #15691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b7a15b
remove sorting bug (but slow)
yoann9344 Sep 5, 2019
e6f1089
add try exept
yoann9344 Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/json/encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,10 @@ def _iterencode_dict(dct, _current_indent_level):
item_separator = _item_separator
first = True
if _sort_keys:
items = sorted(dct.items())
try:
items = sorted(dct.items())
except(TypeError):
items = sorted(dct.items(), key=lambda kv: str(kv[0]))

@serhiy-storchaka serhiy-storchaka Sep 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work correctly for True, False, None and some int and float subclasses (like IntEnum).

@yoann9344 yoann9344 Sep 8, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed it doesn't work. I have no idea how to correct it.

else:
items = dct.items()
for key, value in items:
Expand Down