Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
====================================================
+ Coverage 98.16743% 100.00000% +1.83257%
====================================================
Files 128 128
Lines 19972 19588 -384
Branches 1399 1335 -64
====================================================
- Hits 19606 19588 -18
+ Misses 359 0 -359
+ Partials 7 0 -7 🚀 New features to boost your workflow:
|
Contributor
|
LLM generated docs have always seemed kind of pointless. I guess I can see cases where it helps (non-contributor docs, a really good model, well written and concise prose) but that's not this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3116.
Add a contributor-guide section covering the attrs choices already used in Trio:
The section links to the relevant attrs documentation and includes a small runnable example. No runtime code or dependency changes.
Validation on current main 7e0dc2d, CPython 3.11.17/Linux:
sphinx-build -E -b html -W --keep-going) pass with zero warnings both before and after this patch.test_pyright_recognizes_init_attributespasses with the alias plugin loaded before Trio's pytest plugin, as in CI. Unrelated auto-loaded plugins were disabled for this focused check.The earlier November 8 build used unpinned documentation dependencies and had 17 baseline warnings. The validation above is a fresh run with the current pinned environment, not a reinterpretation of that earlier result. No full runtime suite, type-checker or CI result is claimed for this documentation-only change.
Prepared with AI assistance.