Repository navigation
Run ASYNC123 from flake8-async in pre-commit - #3587
Closed
jeeeeetshahhhhh wants to merge 1 commit into
Closed
jeeeeetshahhhhh wants to merge 1 commit into
jeeeeetshahhhhh wants to merge 1 commit into
Conversation
Contributor
|
Let's not pick and choose flake8-async things to use. |
CoolCat467
added
the
LLM Slop
Author
I tried working on this by adding flake8-async to pre-commit, but I see the concern about only enabling ASYNC123. Would the preferred approach be to enable the full set of flake8-async checks for the Trio source, rather than selecting individual rules? If so, I'd be happy to take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3396.
Ruff already checks the ASYNC rules it supports. This adds flake8-async to pre-commit for ASYNC123, which is not implemented in Ruff and catches lost exception context when unwrapping single-exception groups. Scope the hook to Trio source files and exclude test fixtures, where the behavior is intentionally exercised.
Validation:
pre-commit run flake8-async --all-filespassed.