Repository navigation
Conversation
A NaN jump permanently corrupts the virtual clock and makes later valid jumps ineffective. Reject it before changing the clock state, matching the validation already applied to MockClock.rate.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19555 19571 +16
Branches 1330 1331 +1
===============================================
+ Hits 19555 19571 +16
🚀 New features to boost your workflow:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3578.
A NaN jump permanently corrupts
MockClock's virtual time, so subsequent valid jumps cannot recover it. Reject NaN before modifying the clock, while retaining the existing negative-jump error and zero/positive-jump behavior.Adds regression coverage for stationary and advancing clocks, verifies that rejection preserves the time and permits later valid jumps, and updates the documented exception and release note.
Verification
ValueError).mypy --platform linux src/trio: passed, 144 source files.Broader checks and local limitations (Python 3.12.3, Linux)
The full slow suite produced 876 passed, 23 skipped, 2 xfailed and 2 failures. Both failures are existing
test_static_tool_sees_class_memberscases for Jedi/Mypy reportingtrio.WindowsPath.ntpath; reproduced unchanged on a clean upstream worktree at93e6b2e.The repository-wide Mypy command including docs encounters an existing
docs/source/conf.py:285Sphinx inventory typing error, also reproduced on that clean upstream worktree. Library/source Mypy passes with the repository's default Python 3.10 target.AI-assisted implementation and local verification; no separate human review is claimed.