[akx]

Since hline is the primitive used for scanline-filling polygons, this will speed that up too (especially in the translucent cases), there's just no benchmark for it (yet? I can add one).

In the RGB(A) hline case, the speedup is unswitch (two unswitches actually) and autovectorization.

And the -97.3% reduction below is just... not painting when the ink is entirely translucent. 😄

EDIT: Translucent ink speedup doesn't show up here anymore since it was separately implemented in #10219 afterwards.

This also fixes the inadvertent performance regression from #9982's augmentation commits.

[codspeed]

Merging this PR will improve performance by 67.79%

3 warnings

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 6 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 6 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 6 improved benchmarks
✅ 662 untouched benchmarks
⏩ 352 skipped benchmarks¹

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
⚡	test_draw_lines_blend[1237x811-255]	1,059.8 µs	496 µs	×2.1
⚡	test_draw_lines[1237x811-L]	650.8 µs	384.6 µs	+69.22%
⚡	test_draw_lines[1237x811-RGBA]	704.6 µs	438.2 µs	+60.81%
⚡	test_draw_lines[1237x811-LA]	705.3 µs	438.9 µs	+60.69%
⚡	test_draw_lines[1237x811-RGB]	720 µs	453.8 µs	+58.66%
⚡	test_draw_lines_blend[1237x811-127]	1,060.1 µs	704.1 µs	+50.55%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing akx:faster-rect-and-line (91fb643) with main (4d01b94)}

Footnotes

1. 352 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[aclark4life]

Could you add a release note under "Other changes"? Something like:

Faster drawing
^^^^^^^^^^^^^^

Drawing rectangles, polygons and lines is faster, particularly with translucent ink.

[radarhere]

I'm reluctant to add in 92 lines for the 'vline' commit, so I ran this PR excluding that single commit in radarhere#40... and it became faster? My PR reported 68.01%, compared to this PR's 67.9%.

[akx]

Mm, looks like none of the current benchmarks actually end up measuring vline so that 0.11 percentage point is benchmarks missing branches.

With a benchmark that draws a grid (hlines and vlines), I'm seeing a speedup of up to 1.2x; outlined rects also need vline and those become 1.7x to 2.1x. Would you like me to add these benchmarks too?