Fix JavaScript extraction of escaped Unicode surrogate pairs - #1337
Open
WenJing95 wants to merge 2 commits into
Open
Fix JavaScript extraction of escaped Unicode surrogate pairs#1337WenJing95 wants to merge 2 commits into
WenJing95 wants to merge 2 commits into
Conversation
Combine surrogate pairs after concatenating literals without crossing message or context argument boundaries. Add regression coverage for quote styles, empty fragments, unmatched surrogates, escaped backslashes, plural messages, and contexts. Validation (Linux, CPython 3.13.5): - 51 JavaScript extraction and lexer tests passed. - The added tests produced 7 failures before the fix. - 5 extraction -> PO -> MO -> GNUTranslations round-trips passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript literals such as
gettext("\uD83D\uDE00")currently extract two surrogate code points, producing an incorrect PO message ID and aUnicodeEncodeErrorwhen compiling an MO catalog. Combine valid UTF-16 pairs during string unquoting so escaped and literal characters produce the same message ID, while preserving unmatched surrogates.Add regression coverage for ordinary strings, template strings, pair boundaries, and escaped backslashes.
Validation:
pytest tests/messages -q(405 passed),pre-commit run --all-files --show-diff-on-failure, and an extraction → PO → MO translation round-trip.