Repository navigation
Conversation
PR overviewNo security issues were found in this pull request. Reviews
|
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1328.
PoolByteStream.aclose()marked itself closed before closing its inner stream. An ordinary close exception then made every retry a no-op, leaving the associated pool request registered. The sync path had the same failure.Roll back
_closedonly when the inner close raises, preserving its successful-close idempotence. Regression tests cover a failing first close, successful retry, pool-slot release, and a no-op third close for asyncio, trio and sync.Verified with
scripts/check,scripts/test(2,132 passed, 100% coverage), and a fresh installedhttpcore2wheel exercised with the reported reproduction on Python 3.15.