Add support for cache#626
Merged
Merged
Conversation
|
|
|
any update on this? |
Author
|
I would love to have this merged as I don't want to fork the project... But if it's not merged soon I guess I'll have to...:/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for HAProxy cache. All options are supported (https://www.haproxy.com/documentation/haproxy-configuration-manual/latest/#6).
Additional Context
I did some simple testing with puppet apply and from the looks of it, it works as it should.
I'm not sure how to go about default values. Should they be set with haproxy defaults or left undef as they can change on haproxy side.
Related Issues (if any)
Checklist
puppet apply)