Skip to content

Fix vxrm clear masks - #488

Open
flaviens wants to merge 1 commit into
pulp-platform:mainfrom
flaviens:fix/vector-csr-clear-mask
Open

Fix vxrm clear masks#488
flaviens wants to merge 1 commit into
pulp-platform:mainfrom
flaviens:fix/vector-csr-clear-mask

Conversation

@flaviens

Copy link
Copy Markdown

The clear mask for vxrm was cast to one bit. Keep both mask bits.

Verification: Verilator elaboration.

@flaviens
flaviens marked this pull request as ready for review August 22, 2026 06:25
Copilot AI lite review requested due to automatic review settings August 22, 2026 06:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CSR clear-mask handling for vxrm by using the correct 2-bit vxrm_t type during mask construction, ensuring both vxrm bits are preserved/cleared as intended during CSR clear operations.

Changes:

  • Update CSR_VXRM clear-mask casting to vxrm_t (instead of vxsat_e) so the mask remains 2 bits wide.
  • Update CSR_VCSR clear-mask casting for the embedded vxrm field to vxrm_t.
  • Document the fix in the changelog.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
hardware/src/ara_dispatcher.sv Fixes vxrm CSR clear-mask type casting to preserve both vxrm bits in clear operations.
CHANGELOG.md Adds a “Fixed” entry describing the vxrm clear-mask correction.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants