Repository navigation
fix(langneg): normalize fallback variant casing - #677
Open
poplolioi11 wants to merge 1 commit into
Open
poplolioi11 wants to merge 1 commit into
poplolioi11 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #676.
LocaleWrapperextracts fallback variants from the original tag, retaining their letter case, while range matching compares those variants using strict equality. As a result, changingoxendicttoOXENDICTcan change which available variant is selected undermatchingandlookup.Lowercase only the extracted fallback variant. Native
Intl.Localeconstruction and its input validation stay unchanged, and the public result still returns the original available-locale string (for example,en-US-OXENDICT). This follows the case-insensitive matching requirement in RFC 4647 section 2.Added eight public-API regression/control cases: lowercase, uppercase available variant, uppercase requested variant, and an invalid non-ASCII variant, under both strategies.
Validation on Node 24.22.1:
fluent-langneg/test/langneg_test.js.Intl.Locale.prototype.variants: the four uppercase cases select the wrong variant before the patch and the expected variant afterward.AI assistance: Codex helped prepare the patch, tests and description; Gemini independently reviewed the final diff. All execution results above were verified locally.