Repository navigation
Preserve full float precision in strands shader literals - #9408
Open
harshiltewari2004 wants to merge 1 commit into
Open
harshiltewari2004 wants to merge 1 commit into
harshiltewari2004 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8884
Changes:
toFixed(4), so small values like0.00001became0.0000and others were rounded. Both backends now use a sharedformatFloatLiteral()helper (inir_types.js), following @bhabishnu's suggestion on the issue:Number.isInteger(v) ? v.toFixed(1) : String(v). This keeps full precision, keeps integer values in float form (1.0), and uses exponent form only at extreme magnitudes, which both GLSL and WGSL accept.0.00001and0.123456intact.Out of scope: @bhabishnu also noted that raw numeric arguments (e.g.
abs(3000000000)) go through a separate path and differ between WebGL and WebGPU. Happy to follow up on that separately.Note:
handle passing a value from a vertex hook to a fragment hook with swizzle assignmentintest/unit/webgpu/p5.Shader.jsfails locally for me on currentmainboth with and without this change, so it looks pre-existing and unrelated.PR Checklist
npm run lintpasses