fix : other shape use the shape class also add new roundrect Primitive#8899
Merged
Merged
Conversation
Member
Author
|
@davepagurek, can you please review the changes and add comments? |
davepagurek
reviewed
Jun 10, 2026
davepagurek
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks good! Do we already have visual tests for rectangles, both rounded and not rounded, in 2D mode, or do we need to add some to make sure it renders the same?
Member
Author
|
we have visual test only for rectangle but we need to add for rounded rect |
…04/p5.js into fix/other-shape-to-class
Contributor
|
Awesome, looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8277
Changes:
Renderer2D refactor
line(),point(),triangle(),quad(), andrect()to create and renderp5.Shapeinstances throughdrawShape().New RectPrimitive
RectPrimitiveto represent rectangles and rounded rectangles as shape primitives.Shape.rectPrimitive()helper.Screenshots of the change:
PR Checklist
npm run lintpasses