Skip to content

fixed the bottom line when in split view in side nav - #1642

Merged
doradocodes merged 2 commits into
processing:mainfrom
aarjav-shukla:fixing-ref-side-nav
Nov 6, 2026
Merged

doradocodes merged 2 commits into
processing:mainfrom
aarjav-shukla:fixing-ref-side-nav

Conversation

@aarjav-shukla

Copy link
Copy Markdown
Contributor

fixes #1296

Now there isnt a bottom line visible under secondary side nav when in split view that

its only visible when in mobile view that seperates it from page content

image

Mobile view

image

@aarjav-shukla

Copy link
Copy Markdown
Contributor Author

@Nwakaego-Ego @doradocodes aplogies for opening the pr after 2 weeks
was busy in college exams !
eagerly waiting for the reviews

@aarjav-shukla

Copy link
Copy Markdown
Contributor Author

Just wanted to mention that the build check is currently failing during the Playwright Chromium installation step due to an unsupported Ubuntu 26.04 environment.

The tests, lint, typecheck, and application build all completed successfully. The failure occurs before the accessibility tests can run.

This appears to be unrelated to the changes in this PR. Please let me know if there's anything I should address on my end.

Thanks!

@Nwakaego-Ego

Copy link
Copy Markdown
Contributor

Hi @aarjav-shukla, thank you for the fix. I checked the change locally, and it looks good.

The workflow failure is unrelated to this CSS change. The version of Playwright used by the branch did not support Ubuntu 26.04. PR #1643 has since updated Playwright on main, so please update your branch with the latest main and rerun the checks.

Thank you.

@aarjav-shukla

Copy link
Copy Markdown
Contributor Author

@Nwakaego-Ego thankss for the review and the update
yeah now it passes the build check

@doradocodes
doradocodes merged commit 3aff29c into processing:main Nov 6, 2026
4 checks passed
@doradocodes

Copy link
Copy Markdown
Contributor

@Nwakaego-Ego can you create a branch to fix on v1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[main & 2.0] There shouldn’t be a horizontal rule visible at the bottom of the side navigation. This is only visible with the split side navigation.

3 participants