fix: homepage header taking full viewport, hiding hero image (#1459)#1468
Closed
SOUMITRO-SAHA wants to merge 1 commit into
Closed
fix: homepage header taking full viewport, hiding hero image (#1459)#1468SOUMITRO-SAHA wants to merge 1 commit into
SOUMITRO-SAHA wants to merge 1 commit into
Conversation
…ing#1459) Use dvh with vh fallback for header height, ensure 750px min-height so hero image is visible above fold on mobile.
Contributor
|
Closing this PR as the issue is no longer relevant. See my last comment on the Issue for further explanation. Thanks for looking into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1459
On mobile, the homepage header was set to 100vh, pushing the hero image below the fold. Users had to scroll to see it.
Changes: