Implement cross-file effect resolution#1344
Open
lionel- wants to merge 2 commits into
Open
Conversation
lionel-
force-pushed
the
oak-nse/5-eager-attach
branch
from
July 17, 2026 08:56
772463a to
d43a67a
Compare
lionel-
force-pushed
the
oak-nse/6-resolver
branch
2 times, most recently
from
July 17, 2026 11:26
019fa41 to
9e15505
Compare
lionel-
force-pushed
the
oak-nse/5-eager-attach
branch
from
July 17, 2026 11:26
d43a67a to
4dd85c0
Compare
lionel-
force-pushed
the
oak-nse/6-resolver
branch
from
July 17, 2026 13:55
9e15505 to
3ee2789
Compare
lionel-
force-pushed
the
oak-nse/5-eager-attach
branch
from
July 17, 2026 13:55
4dd85c0 to
3a2d3a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1338
Branched from #1343
This PR ties effects support together.
SalsaImportsResolver::resolve_effects()now resolves the effects of a function call in exactly the way the definition side resolves a name, with import-layer chains.Shadowing is export-driven: a layer that binds the name but carries no effect (a plain export, a sibling definition, a namespace import) still shadows any deeper effect. If a
library(evil)overwritessource(),library(), orassign(), the effects (or absence thereof) from evil exports win.To avoid Salsa cycles, effect resolution always uses the eager (predecessors-only) collation view, even for a lazy callee. If a later sibling shadows effects in a lazy call, we'll emit a diagnostic instead (NYI).
To share the search-path model, the import layer chain is extracted into
CrossFileLayers/CollationView/cross_file_layers(), which support both the definition and effect sides.