bug: CBC mode test fails randomly on out of bounds

Describe the bug
Apparently we can, due to rng, get an out of bounds error in the CBC encryption mode. See: https://github.com/pluto/ronkathon/actions/runs/13179737670/attempts/1

To Reproduce
N/A?

I would suggest restricting the values/length of the generated numbers

Do you know that these numbers being hit are sometimes too big/small?

// remove PKCS#7 padding by checking the last byte and removing all intermediate bytes
    let last_byte = plaintext[plaintext.len() - 1];
    if plaintext[plaintext.len() - last_byte as usize] == last_byte {
      plaintext.truncate(plaintext.len() - last_byte as usize);
    }

this is where the failure stems from, it seems last_byte is zero

Ah 1/256 chance then. No wonder we haven't seen this but still likely enough to fail.

@mahmudsudo

@mahmudsudo good find there by the way. Marked this as "good first issue" since this shouldn't be too hard to fix.

On second thought , a little check on the value of last_byte might help

can i take the issue now ?

Navigation Menu

Repository navigation

bug: CBC mode test fails randomly on out of bounds #218

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

bug: CBC mode test fails randomly on out of bounds #218

Description

Activity

mahmudsudo commented on Feb 10, 2025

Autoparallel commented on Feb 17, 2025

mahmudsudo commented on Feb 18, 2025

Autoparallel commented on Feb 18, 2025

Autoparallel commented on Feb 18, 2025

mahmudsudo commented on Feb 19, 2025

mahmudsudo commented on Nov 16, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions