Skip to content

Add metrics prerequisites and verification steps to install and migration guides - #66

Merged
marcopiraccini merged 1 commit into
mainfrom
v3-v4-migration-manual-fixes
Aug 28, 2026
Merged

Add metrics prerequisites and verification steps to install and migration guides#66
marcopiraccini merged 1 commit into
mainfrom
v3-v4-migration-manual-fixes

Conversation

@marcopiraccini

@marcopiraccini marcopiraccini commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Fixes to MANUAL.md and MIGRATING-v3-to-v4.md after a full test of the install and migration procedures.

  • Document the Prometheus data ICC actually needs: scraping kubelet /metrics/cadvisor and kube-state-metrics, with kube-state-metrics exporting the platformatic.dev/monitor Pod label, plus the metrics.k8s.io resource metrics API required by the ICC HPA.
  • Add Prometheus verification queries to the migration guide that mirror the queries ICC runs (container_cpu_usage_seconds_total, CPU limits/requests, label-filtered kube_pod_labels), and a matching troubleshooting entry in the manual for empty CPU metrics.
  • Run helm upgrade with --wait --timeout 10m in both guides so a failed rollout surfaces instead of the command returning immediately.
  • Correct the scaler cooldown comments: 300 preserves the chart v3 behavior, the v4 default is 15, and the value gates scale-up only (scale-down uses a shorter derived 60-180s cooldown).

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
@marcopiraccini marcopiraccini changed the title fixes after full test Add metrics prerequisites and verification steps to install and migration guides Aug 27, 2026

@leorossi leorossi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcopiraccini
marcopiraccini merged commit 166164c into main Aug 28, 2026
1 check passed
@marcopiraccini
marcopiraccini deleted the v3-v4-migration-manual-fixes branch August 28, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants