Add metrics prerequisites and verification steps to install and migration guides - #66
Merged
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to
MANUAL.mdandMIGRATING-v3-to-v4.mdafter a full test of the install and migration procedures./metrics/cadvisorand kube-state-metrics, with kube-state-metrics exporting theplatformatic.dev/monitorPod label, plus themetrics.k8s.ioresource metrics API required by the ICC HPA.container_cpu_usage_seconds_total, CPU limits/requests, label-filteredkube_pod_labels), and a matching troubleshooting entry in the manual for empty CPU metrics.helm upgradewith--wait --timeout 10min both guides so a failed rollout surfaces instead of the command returning immediately.cooldowncomments:300preserves the chart v3 behavior, the v4 default is15, and the value gates scale-up only (scale-down uses a shorter derived 60-180s cooldown).