Skip to content

owners: remove develop docs aliases - #24543

Merged
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
lilin90:update-owners
Oct 23, 2026
Merged

ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
lilin90:update-owners

Conversation

@lilin90

@lilin90 lilin90 commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

What is changed, added, or deleted? (Required)

Remove the obsolete sig-develop-docs-approvers and sig-develop-docs-reviewers configuration from develop/OWNERS and OWNERS_ALIASES. Keep the area/develop automatic label configuration.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • Related code change PR links (if applicable):
  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Chores
    • Updated development-area approval assignments and removed the reviewer assignment. Approval membership guidance was also clarified. These administrative changes do not affect end-user functionality.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 03:49
@ti-chi-bot ti-chi-bot Bot added the area/develop This PR relates to the area of TiDB App development. label Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

The develop docs approver alias now lists only seominjea1942, and the reviewer alias is removed. The membership comment in develop/OWNERS now refers to approvers and /OWNERS_ALIASES; its approver, reviewer, and area/develop entries remain.

Changes: Develop docs ownership

Layer / File(s) Summary
Update develop docs ownership
OWNERS_ALIASES, develop/OWNERS
The approver alias now lists only seominjea1942, and the reviewer alias is removed. The membership comment refers to approvers and /OWNERS_ALIASES; the approver, reviewer, and area/develop entries remain.

Priority: ⚪ Pending latest changes

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: qiancai

Merge Risk: 🟡 Moderate · up to bb233

Develop documentation still names a reviewer team that no longer exists in the ownership aliases. Remove the stale reviewer entry before merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the removal of the develop documentation aliases.
Description check Passed The description identifies the removed configurations, retained label configuration, target versions, alias change, and AI involvement. Optional reference links are blank, but the required content is …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description identifies the removed configurations, retained label configuration, target versions, alias change, and AI involvement. Optional reference links are blank, but the required content is complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lilin90 lilin90 self-assigned this Oct 23, 2026
@lilin90
lilin90 requested a review from qiancai October 23, 2026 03:50
@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Oct 23, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Oct 23, 2026
@lilin90 lilin90 added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 23, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-10-23 04:04:59.194334767 +0000 UTC m=+88636.686047027: ☑️ agreed by qiancai.

Comment thread OWNERS_ALIASES
Comment thread develop/OWNERS
Comment thread OWNERS_ALIASES Outdated
Comment thread develop/OWNERS
Comment thread OWNERS_ALIASES

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: pingcap/docs
  • Branch: master
  • File: .coderabbit.yaml
  • Commit: 7a24ee1
  • Layers: Repository YAML
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 994c33dd-704f-4999-92f1-dffdd5991bae
📥 Commits

Reviewing files that changed from the base of the PR and between 23c37ff and bb23333.

📒 Files selected for processing: 2
  • OWNERS_ALIASES
  • develop/OWNERS
💤 Files with no reviewable changes: 1
  • OWNERS_ALIASES

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread develop/OWNERS
Comment thread develop/OWNERS Outdated
@ti-chi-bot

ti-chi-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

@qiancai: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 added the lgtm label Oct 23, 2026
@lilin90

lilin90 commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilin90 lilin90 added the ONCALL Relates to documentation oncall. label Oct 23, 2026
@ti-chi-bot ti-chi-bot Bot added the approved label Oct 23, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit d6df199 into pingcap:master Oct 23, 2026
12 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #24544.
But this PR has conflicts, please resolve them!

@lilin90
lilin90 deleted the update-owners branch October 23, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/develop This PR relates to the area of TiDB App development. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants