fix(cli): pin Inno Setup installer download to a GitHub release - #1239
Merged
Conversation
jrsoftware.org's download.php/is.exe shortcut no longer serves the installer binary directly -- it now returns an HTML landing page. The Windows installer build step was downloading that HTML page and handing it to wine, which failed with "not supported on this system" while trying to execute it. Pin to the last unified (non x86/x64-split) release on GitHub, since the Dockerfile's WINEARCH is win32 and Inno Setup 7.x split the installer into separate x86/x64 builds.
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
jablan
requested review from
Sven Dunemann (forelabs) and
Sönke Behrendt (theSoenke)
August 24, 2026 15:30
Sven Dunemann (forelabs)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build/innosetup/Dockerfile) downloads Inno Setup viahttp://www.jrsoftware.org/download.php/is.exe. That shortcut no longer serves the binary directly -- it now returns an HTML "Downloads" landing page (confirmed by curling it: 10,478 bytes of HTML, matching the size seen in the failing CI logs).winethen fails trying to execute that HTML as a binary (not supported on this system), breaking the Windows installer step of every CLI release.innosetup-6.7.3.exe) instead, scraped from the same landing page. Verified it's a realPE32 executable ... Intel i386binary, matching the Dockerfile'sWINEARCH win32. Deliberately avoided the newer 7.1.0 release since Inno Setup split that into separate x86/x64 installers, which could introduce a second compatibility issue with the existing win32 wine setup.Test plan
build-clijob) passesreleasejob inphrase-cli's next release run gets past the "Build client" / installer step