Skip to content

fix(Table): pass variant to calculateColumns for radio styling #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opacut wants to merge 1 commit into
base: main
Choose a base branch
from
+800 −28
Open

fix(Table): pass variant to calculateColumns for radio styling #12451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-table/src/deprecated/components/Table/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ class Table extends Component<TableProps, {}> {
actionsToggle,
onFavorite,
canSortFavorites,
variant,
// order of columns: Collapsible | Selectable | Favoritable
firstUserColumnIndex: [onCollapse, onSelect, onFavorite].filter((callback) => callback).length
});
Expand Down
19 changes: 19 additions & 0 deletions packages/react-table/src/deprecated/components/Table/__tests__/Table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,25 @@ describe('Table', () => {
expect(asFragment()).toMatchSnapshot();
});

test('Compact table with Radio select', () => {
const onSelect: OnSelect = () => undefined;
const { asFragment } = render(
<Table
aria-label="Compact table with radio"
variant={TableVariant.compact}
selectVariant={RowSelectVariant.radio}
onSelect={onSelect}
cells={columns}
rows={rows}
>
<TableHeader />
<TableBody />
</Table>
);

expect(asFragment()).toMatchSnapshot();
});

test('Control text table', () => {
const controlTextColumns: ICell[] = [
{ ...(columns[0] as object), transforms: [nowrap] },
Expand Down
Loading
Loading