fix: copy jinja_options per-instance to prevent shared mutable class default#6080
Closed
webdevdot wants to merge 2 commits into
Closed
fix: copy jinja_options per-instance to prevent shared mutable class default#6080webdevdot wants to merge 2 commits into
webdevdot wants to merge 2 commits into
Conversation
…default
Class-level jinja_options = {} is shared across all Flask instances and
subclasses, so mutations on one instance silently affect all others.
Copy it in __init__ so each app gets its own dict.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jinja_options: dict[str, t.Any] = {}atsansio/app.py:248is a class-level mutable dict shared across all Flask instances and subclasses.jinja_optionson one instance silently bleed into all other instances.__init__withself.jinja_options = dict(self.__class__.jinja_options).Test plan
app1.jinja_options; verifyapp2.jinja_optionsis unaffected.jinja_options; verify instances of both the base and the subclass have independent dicts.🤖 Generated with Claude Code