Run Copr builds directly and use LLMs only for diagnosis - #808
Conversation
PR Summary by QodoRun Copr builds deterministically with diagnosis-only LLMs
AI Description
Diagram
High-Level Assessment
Files changed (12)
|
Code Review by Qodo
1. Consolidated builds never reach Copr
|
e911d1c to
4a1768d
Compare
nforro
left a comment
There was a problem hiding this comment.
Just curious, what was the motivation for this change?
mainly to reduce token spend on a workflow, where LLM isn't that needed. thanks for the comments, I'll make the changes. |
4a1768d to
6923833
Compare
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 6923833 |
6923833 to
7d732f1
Compare
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 7d732f1 |
Call the existing build tool deterministically so successful builds no longer require model orchestration. Use a two-step BuildWorkflow and centralize opt-in typed result validation in run_tool. Migrate backport, inheritance, rebase, MR updates, and consolidation while preserving their timeout and retry policies. Keep rebuild and the incremental backport repair loop unchanged. Use a stable Copr project name for consolidations without Jira footers without changing Jira metadata. Require both gateway log tools for remote extraction; otherwise retrieve logs in a local temporary directory. Explicitly abort and drain the workflow on cancellation. Add regression tests for gateway decoding, zero-LLM success handling, error classification, cancellation, no-Jira consolidation retries, and all log-tool availability combinations. Document the shared build flow. Validation: make check-in-container passed with rebuilt test images (6 skipped tests), including the MCP installation smoke test. Ruff lint and format checks passed. Assisted-by: Codex
7d732f1 to
d595eb3
Compare
Call the existing build tool deterministically so successful builds no longer require model orchestration. Share the structured Copr result schema and invoke a diagnosis-only agent for failed builds with logs.
Migrate backport, inheritance, rebase, MR updates, and consolidation while preserving their timeout and retry policies. Keep rebuild and the incremental backport repair loop unchanged.
Add regression tests for gateway decoding, zero-LLM success handling, error classification, cancellation, and diagnosis without resubmission. Document the shared build flow and its dry-run behavior.
Validation: 64 focused container tests passed; Ruff lint and format checks passed. Broader container testing found two gateway startup test failures and the same missing-MCP-settings error in the install smoke test. The gateway test failures also reproduce on unchanged commit 00d2ba6. Other component suites passed.
Assisted-by: Codex
I've ran e2e test for build succeeding on first try and build failing on the first time with the need to fix it. No regressions were found. GPT-6 Astra estimates around 8% of token cost savings per backport task.