Fix errors for malformed LPM and range matches - #163
Merged
jafingerhut merged 1 commit intoSep 6, 2026
Merged
Conversation
Format the diagnostic strings before constructing UserError so malformed prefix lengths and ranges produce the intended input errors. Add four regression cases covering both exception handlers and their messages. Refs #162 AI assistance was used to identify and reproduce the issue and prepare the patch, regression tests, and this commit message. Signed-off-by: Jiajun He <80980027+sillage-hjj@users.noreply.github.com>
jafingerhut
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162
Problem
Malformed LPM prefix lengths and range expressions, such as
10.0.0.0/abcand10..20..30, raiseAttributeError: 'UserError' object has no attribute 'format'instead of the intendedUserErrorexplaining the invalid input.Both error handlers call
.format()on aUserErrorinstance rather than on the message string. Since the exception object has no such method, the resultingAttributeErrorhides the intended diagnostic.Changes
UserError.Testing
AttributeErroragainst the unmodified upstream implementation.AI assistance was used to identify and reproduce the issue and regression tests, translate the contributor's description.